Toolbar layout properties, notably --urlbar-container-height, is
re-computed when window modal dialog is closed and the values would be
totally incorrect if the toolbars are hidden at that time. This fixes#582
and likely several other issues as well.
On Windows 10 at least, the -1px static bottom margin we were using
causes a empty row of pixels to appear between tabs toolbar and nav-bar
when: 1. compact mode is used and 2. window scaling is at least 120% and
3. menubar is disabled.
This might be useful to be made to apply to Windows only, but that needs
testing. I suspect that this is also somewhat system dependent or
depends on more than just display scaling and density.
Since Tabs toolbar and menubar are direct children of toolbox
.browser-toolbar selector would apply to them as well causing certain
rendering issues such as slight movements in buttons when toolbox is
hovered
Tab preview panel can sometimes cause what is possibly style
invalidation problem where the panel would jump around and even be
outside the window. This is especially likely to happen with
autohide_main_toolbar when tabs are overflowing.
Revamped sidebar design sets non-auto z-index for toolbox and sidebar
items. We need to restore them to auto for correct (in our perspective)
layering.
Previously if Firefox was in fullscreen mode and toolbars would autohide
(per Firefox normal setting) then this style would cause content area to
be pushed way too far up because of computed margin-top on
navigator-toolbox. This patch makes navigator toolbox use margin
computed from tabs toolbar height.
These rules were once needed to make sure that invisible toolbox didn't
steal pointer events from sidebar. Not needed anymore, and this removal
also fixes#305
For some reason individual .bookmark items in the toolbar are being
rendered in Firefox 96, even though the toolbar itself is hidden. This
patch applies a simple visibility:hidden to all of them.
Bookmark items in the toolbar may not be same height on all systems,
generally the text size on Linux is bigger than on Windows for example.
This patch changes the height to use min-height on bookmark items and
removes their individual block padding. Thus, thee effectively have
variable block-padding depending on the text size.
In addition this patch removes few pre-proton workarounds because those
don't need to be supported any more.
