From df4462f5d98266012569768ed570db5aa080030b Mon Sep 17 00:00:00 2001 From: MrOtherGuy Date: Fri, 22 Dec 2023 06:25:13 +0200 Subject: [PATCH] Remove opacity changes from titlebar - fixes #331 Bug 1870803 introduced a transition to window activeness visuals. But the lowered opacity breaks the z-index hackery we use to let window-controls show through nav-bar. This patch basically undoes the changes from bug 1870803 --- chrome/hide_tabs_toolbar.css | 6 +++++- chrome/hide_tabs_toolbar_w_alltabs_button.css | 7 ++++++- chrome/hide_tabs_with_one_tab_w_window_controls.css | 7 ++++++- chrome/navbar_tabs_oneliner_tabs_on_left.css | 6 +++++- chrome/tabs_below_content.css | 6 +++++- 5 files changed, 27 insertions(+), 5 deletions(-) diff --git a/chrome/hide_tabs_toolbar.css b/chrome/hide_tabs_toolbar.css index 257db60..a2b9059 100644 --- a/chrome/hide_tabs_toolbar.css +++ b/chrome/hide_tabs_toolbar.css @@ -16,7 +16,11 @@ Window controls will be all wrong without it :root[tabsintitlebar]{ --uc-toolbar-height: 40px; } :root[tabsintitlebar][uidensity="compact"]{ --uc-toolbar-height: 32px } - +#titlebar{ + will-change: unset !important; + transition: none !important; + opacity: 1 !important; +} #TabsToolbar{ visibility: collapse !important } :root[sizemode="fullscreen"] #TabsToolbar > :is(#window-controls,.titlebar-buttonbox-container){ diff --git a/chrome/hide_tabs_toolbar_w_alltabs_button.css b/chrome/hide_tabs_toolbar_w_alltabs_button.css index 4f2f9ee..d3cfccd 100644 --- a/chrome/hide_tabs_toolbar_w_alltabs_button.css +++ b/chrome/hide_tabs_toolbar_w_alltabs_button.css @@ -40,4 +40,9 @@ See the above repository for updates as well as full license text. */ #TabsToolbar > .titlebar-spacer{ display: none } #TabsToolbar:not([customizing]){ margin-bottom: calc(0px - var(--tab-min-height) - 2 * var(--tab-block-margin))} -#titlebar{ -moz-appearance: none !important; } +#titlebar{ + -moz-appearance: none !important; + will-change: unset !important; + transition: none !important; + opacity: 1 !important; +} diff --git a/chrome/hide_tabs_with_one_tab_w_window_controls.css b/chrome/hide_tabs_with_one_tab_w_window_controls.css index 4df6631..9d218ab 100644 --- a/chrome/hide_tabs_with_one_tab_w_window_controls.css +++ b/chrome/hide_tabs_with_one_tab_w_window_controls.css @@ -20,7 +20,12 @@ Window controls will be all wrong without it :root{ --uc-menubar-vertical-overlap: 28px; /* adjust as necessary */ } -#titlebar{ -moz-appearance: none !important; } +#titlebar{ + -moz-appearance: none !important; + will-change: unset !important; + transition: none !important; + opacity: 1 !important; +} /* We'll use window controls from menubar instead */ #TabsToolbar > .titlebar-buttonbox-container { display: none } /* Hide overflow button unless tabs overflow - is necessary for collpasing tabs with one tab */ diff --git a/chrome/navbar_tabs_oneliner_tabs_on_left.css b/chrome/navbar_tabs_oneliner_tabs_on_left.css index 9548768..e4f376c 100644 --- a/chrome/navbar_tabs_oneliner_tabs_on_left.css +++ b/chrome/navbar_tabs_oneliner_tabs_on_left.css @@ -19,7 +19,11 @@ Window controls will be all wrong without it --uc-toolbar-height: 40px; --uc-urlbar-min-width: 50vw; /* minimum width for opened urlbar */ } - +#titlebar{ + will-change: unset !important; + transition: none !important; + opacity: 1 !important; +} #scrollbutton-up, #scrollbutton-down{ border-block-width: 2px !important; } diff --git a/chrome/tabs_below_content.css b/chrome/tabs_below_content.css index dc388bd..9668764 100644 --- a/chrome/tabs_below_content.css +++ b/chrome/tabs_below_content.css @@ -19,7 +19,11 @@ linux_gtk_window_control_patch.css z-index: 3; visibility: visible !important; } - +#titlebar{ + will-change: unset !important; + transition: none !important; + opacity: 1 !important; +} @media (-moz-bool-pref: "userchrome.force-window-controls-on-left.enabled"), (-moz-gtk-csd-reversed-placement), (-moz-platform: macos){